-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply the latest Beman Standard #15
Apply the latest Beman Standard #15
Conversation
a877c2e
to
81ddf5d
Compare
9b8c5c3
to
1d53fb4
Compare
2fd7687
to
0df2d52
Compare
a78b5c4
to
9913686
Compare
9913686
to
03cbf60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to add suggestions for the file and directory names, but those should be updated as well.
ec6bbc3
to
831f771
Compare
831f771
to
a0381d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the TODOs, which can easily be converted into issues against this repository, and a minor issue, this looks good to merge to me.
if(BUILD_TESTING) | ||
include(GoogleTest) | ||
|
||
add_executable(beman.example.tests) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the target name be beman.example.tests.identity
in case there are multiple test drivers?
- { id: ubuntu-gcc-static-cxx98, platform: ubuntu, cc: gcc, cpp: g++, cmake_args: "-DCMAKE_CXX_STANDARD=98 -DCMAKE_CXX_STANDARD_REQUIRED=on"} | ||
- { id: ubuntu-gcc-static-cxx11, platform: ubuntu, cc: gcc, cpp: g++, cmake_args: "-DCMAKE_CXX_STANDARD=11 -DCMAKE_CXX_STANDARD_REQUIRED=on"} | ||
- { id: ubuntu-gcc-static-cxx14, platform: ubuntu, cc: gcc, cpp: g++, cmake_args: "-DCMAKE_CXX_STANDARD=14 -DCMAKE_CXX_STANDARD_REQUIRED=on"} | ||
- { id: ubuntu-gcc-static-cxx17, platform: ubuntu, cc: gcc, cpp: g++, cmake_args: "-DCMAKE_CXX_STANDARD=17 -DCMAKE_CXX_STANDARD_REQUIRED=on"} | ||
- { id: ubuntu-gcc-static-cxx20, platform: ubuntu, cc: gcc, cpp: g++, cmake_args: "-DCMAKE_CXX_STANDARD=20 -DCMAKE_CXX_STANDARD_REQUIRED=on"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extend compiler / standard versions for build and run on CI: {gcc, clang} x {C++98, C++03, C++11, C++14, C++17, C++20, 'C++23, C++26}.
Is removing CI testing for C++98 <-> C++17 here intentional?
There's only C++20 <-> C++26 testing left.
Apply the Beman Standard to Beman.Example and more tweaks.
Issues:
Updates related to the Beman Standard:
LICENSE.APACHE_LLVM
: Switch from MIT toApache License v2.0 with LLVM Exceptions
.LICENSE.CRITERIA
: already appliedLICENSE.APPROVED
: already appliedFILE.COPYRIGHT
LIBRARY_NAMES
:REPOSITORY_NAME
: renamed toExample
(docs + github)TOPLEVEL.CMAKE
: already applied (rootCMakeLists.txt
, using Ctest)TOPLEVEL.LICENSE
: renamed file toLICENCE
.TOPLEVEL.README
README.TITLE
README.PURPOSE
README.IMPLEMENTS
CMAKE.DEFAULT
CMAKE.SKIP_TESTS
CMAKE.AVOID_PASSTHROUGHS
DIRECTORY.INTERFACE_HEADERS
:DIRECTORY.IMPLEMENTATION_HEADERS
: currently N/ADIRECTORY.SOURCES
:Updates related to docs and usage example:
beman::example::identity
equivalent of std::identitysrc/Beman/Example/tests/example.t.cpp
.examples/sample_usage.cpp
.Updates related to CI/infrastructure/other missing bits:
gcc
,clang
}x {
C++98,
C++03,
C++11,
C++14,
C++17,
C++20, 'C++23
,C++26
}..gitignore
.github/CODEOWNERS